doc: add DataView to crypto.scrypt() and scryptSync()#21549
Closed
Flarna wants to merge 2 commits into
Closed
Conversation
crypto.scrypt() and crypto.scryptSync() support also DataView like most other crypto Apis.
nodejs-github-bot
added
crypto
TimothyGu
approved these changes
Jun 27, 2018
bnoordhuis
approved these changes
Jun 27, 2018
bnoordhuis
left a comment
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
Can you do the same for pbkdf2() and pbkdf2Sync()? Same commit or separate commit, either way is fine.
cjihrig
approved these changes
Jun 27, 2018
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
fast-track
vsemozhetbyt
approved these changes
Jun 27, 2018
lpinca
approved these changes
Jun 27, 2018
Contributor
|
Landed in 4218573 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
Jun 28, 2018
crypto.scrypt(), crypto.scryptSync(), crypto.pbkdf2(), and crypto.pbkdf2Sync() support also DataView like most other crypto APIs. PR-URL: #21549 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 28, 2018
crypto.scrypt(), crypto.scryptSync(), crypto.pbkdf2(), and crypto.pbkdf2Sync() support also DataView like most other crypto APIs. PR-URL: #21549 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.scrypt()andcrypto.scryptSync()support alsoDataViewlike most other crypto Apis.